"Show More" button is still visible even when all items are already shown #9203
Comments
|
Bug originates here. The button shows up when the API returns a full page (10 items in this case) because it assumes more pages to exist (which is correct in 9 out of 10 cases). you happened to have exactly 10 elements, therefore the button showed up but didn't reveal any further items when clicked. If you check your profile again now you will notice that the bug no longer occurs because your recent section now contains 11 items. Question is, how do we tell whether or not another page exists in order to fix this? |
|
Ideally web should be returning some kind of indication that there is more data to be read (like a cursor) if it doesn't already. I guess you could try querying for one more item than you actually need to work around the issue, but it's a hacky solution. Other endpoints have pagination and cursors already. |
|
This seems not to happen anymore |
|
@Theighlin I'm not sure how you determined that, and I'm not sure I agree. The code moved places but it still appears to have a variant of the same bug. |
|
I verified it by checking in game, not sure what you mean by variant of the bug, but in the recent section at least, the button correcty doesn't show when there are too few events, and stops showing once they are all displayed Right, reading above it seems it needs an exact number of recent events? Then i assume if the code wasn't changed it's still there, sorry for jumping to conclusions. |
|
You would have to have an exact number of items that fills the last page exactly returned to reproduce the bug. Checking a few random profiles doesn't really prove the bug is fixed. |
Screenshots or videos showing encountered issue:
(The example shows my profile)
The text was updated successfully, but these errors were encountered: