8000 unpublished/publish toggle only appears after refresh · Issue #565 · prose/prose · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

unpublished/publish toggle only appears after refresh #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samanpwbb opened this issue Aug 7, 2013 · 6 comments
Open

unpublished/publish toggle only appears after refresh #565

samanpwbb opened this issue Aug 7, 2013 · 6 comments
Labels
ui

Comments

@samanpwbb
Copy link
Member

Post page needs to be refreshed before the toggle appears, which can be confusing.
@parkr
Copy link
Contributor
parkr commented Aug 8, 2013

Yeah, I noticed this the other day. I thought it had been removed altogether!

@bcomnes
Copy link
bcomnes commented Aug 8, 2013

So this isn't a mechanism to make sure to preview your post before publishing first? I ran into this starting yesterday :p

@samanpwbb
Copy link
Member Author

Should work like this:

  1. If uncommitted post, "unpublished" button is visible but toggle is disabled both visually & functionally.
  2. If post is committed, "unpublished" button becomes functional: click to switch to "published" state.

@mikemorris mikemorris mentioned this issue May 19, 2014
Closed
@fulldecent
Copy link

Hello and thank you for this issue report. There have been several point releases in Prose since this issue was opened and there has not been much discussion here. I wanted to ask if you could please assist in confirming this is still an issue in the latest version of the product. If it is fixed, please close this issue :-)

Also, if possible could you please

  • Find out if this only affects certain browsers
  • Create a test case -- a list of steps we can perform to reproduce the problem
  • Enable web developer extensions and report the Javascript error message. And when in doubt, be over-descriptive of the bug and how you discovered it.

Since this project is looking for new maintainers (#743), it will be helpful if users can double check the old issues and delete ones that are fixed. This will be super helpful for the new team that works on moving this project forward.

I'm sorry this message is impersonal. And thanks for your help!

@tomsabin
Copy link
Contributor
tomsabin commented Aug 3, 2015

@fulldecent I believe this is still an issue:

  1. If uncommitted post, "unpublished" button is visible but toggle is disabled both visually & functionally.

After pressing "new file" (i.e. an uncommitted post) the button is not visible. The markup in the toolbar.html view doesn't seem to be rendering on the page.

  1. If post is committed, "unpublished" button becomes functional: click to switch to "published" state.

This works as intended

The view doesn't get updated between actions (e.g. previewing), so toolbar.metadata remains undefined, so neither published/unpublished buttons are rendered.

@dawaltconley
Copy link
dawaltconley commented May 2, 2017 •
edited
Loading

Still seems to be an issue.

If uncommitted post, "unpublished" button is visible but toggle is disabled both visually & functionally.

I'm not sure I see why this should be the default functionality though. It makes sense to have a new post be unpublished by default, but why make users unable to publish on the initial commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@samanpwbb @bcomnes @parkr @fulldecent @tomsabin @dawaltconley
0