8000 [Bug]: Multiple Quicksilver_Tests fail when run as part of Quicksilver scheme · Issue #2971 · quicksilver/Quicksilver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

[Bug]: Multiple Quicksilver_Tests fail when run as part of Quicksilver scheme #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
n8henrie opened this issue Sep 30, 2023 · 2 comments · Fixed by #2979
Closed
3 tasks done

[Bug]: Multiple Quicksilver_Tests fail when run as part of Quicksilver scheme #2971

n8henrie opened this issue Sep 30, 2023 · 2 comments · Fixed by #2979

Comments

@n8henrie
Copy link
Member

Before submitting your bug report, please confirm you have completed the following steps

Bug description

Of the tests for the Quicksilver scheme, these three fail when run directly:

  • testClearingFirstPane
  • testClearingSearchStringOnTrigger
  • testThirdPaneClosingBehaviour

All tests, including these, pass when run as part of the Quicksilver Distribution scheme.

Why is this?

Steps to reproduce

  1. In Xcode, select the Quicksilver scheme
  2. Run tests
  3. Observe that these three tests fail

Expected behavior

These tests should pass when run in isolation.

MacOS Version

None

Quicksilver Version

No response

Relevant Plugins

No response

Crash Logs or Spindump

No response

Screenshots

No response

Additional info

These tests fail as part of the Quicksilver Distribution depending on the order in which they are run; if one selects the option to randomize test order, they fail frequently.

The common theme between these three is:

QSInterfaceController *i = [(QSController *)[NSApp delegate] interfaceController];
QSCollectingSearchObjectView *dSelector = (QSCollectingSearchObjectView *)[i dSelector];

When run as part of the Quicksilver Distribution, *i is non-nil. When run as part of Quicksilver, this is a nil pointer.

Similarly, [QSReg preferredCommandInterface] is a nil pointer when run from Quicksilver but non-nil with Quicksilver Distribution: https://github.com/quicksilver/Quicksilver/blob/main/Quicksilver/Code-App/QSController.m#L784

Having a hard time chasing this down, it seems like these tests should be set up to pass from this scheme (since they pass when run from Quicksilver Distribution); if there is some fundamental reason why they won't, perhaps they should be moved?

Any pointers from @pjrobertson @skurfer ?
@n8henrie
Copy link
Member Author
n8henrie commented Oct 5, 2023

The Quicksilver test testActionsForURLObject fails if run immediately after a clean but succeeds if I first change schemes and run tests for Core Support.

@n8henrie
Copy link
Member Author
n8henrie commented Oct 5, 2023

testClearingFirstPane fails even if I run all 3 of the other test sets (QuickStep Core, Core Support, and QuickStep Foundation) first, but succeeds if I run it as part of the Quicksilver Distribution scheme.

This was referenced Oct 13, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run all tests quicksilver/Quicksilver
1 participant
@n8henrie
0