-
Notifications
You must be signed in to change notification settings - Fork 56
Issue compiling xml2 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this is probably r-lib/xml2#231 Any chance that we can fix it, @jimhester ? |
I am not sure how we could fix it.... |
Isn't it enough to add C++-11 to system requirements? c.f. https://cran.r-project.org/doc/manuals/R-exts.html#Using-C_002b_002b11-code |
That seems a pretty onerous system requirement, considering no code in the R package needs C++11, and that it compiles fine on other systems without C++11, and that is used to compile fine before the headers were updated. |
Got it. So this is an Ubuntu bug then. Can we change the compiler flag only for the problematic platform(s)? xml2 already has a configure script, so maybe we could do it there? I understand that this is a pain, but maybe it does not take too much to fix it, Ubuntu 16.04 will be with use for some time.... |
We could, but I haven't looked into it enough to see if there is a better way forward than just using C++11. |
The following seems to work. I added -Wno-ignored-attributes just to reduce the massive Eigen compilation noise.
|
@jackwasey good stuff, thanks! |
I got the same error during installing root_v5.34.36 on ubuntu 18.04. Scanning dependencies of target MathCore |
I fixed this in xml2 by explicitly declaring I think this general issue can be closed though, this is fixed as of xml2 1.2.1 |
Uh oh!
There was an error while loading. Please reload this page.
I am trying to check my package with:
rhub::check_with_sanitizers()
However, I don't get there as the
xml2
package cannot be compiled.I guess this is because mismatching compiler versions or something like this.
The text was updated successfully, but these errors were encountered: