8000 xml_find doens't see added attributes with namespaces · Issue #340 · r-lib/xml2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

xml_find doens't see added attributes with namespaces #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ostroganov opened this issue May 23, 2021 · 1 comment
Open

xml_find doens't see added attributes with namespaces #340

ostroganov opened this issue May 23, 2021 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@ostroganov
Copy link

I'm trying to modify xml by adding child nodes with attributes, and then I'm looking for the subset of added nodes with attributes I just added:

library(xml2)
doc <- read_xml('<?xml version="1.0" encoding="UTF-8"?><bookstore xmlns:xxx="https://www.w3.org/"><book name="Harry Potter 1"></book></bookstore>')

node <- xml_find_first(doc, "book")
xml_add_child(node, .value="link", "xxx:resource"="http://harry_potter.com")

# Now, will try to find the node just added:
xpath <- "//book/link[@xxx:resource=\"http://harry_potter.com\"]"

# results 1:
xml_find_all(doc, xpath)
# nothing found: {xml_nodeset (0)}
# that's wrong

# saving to temporary file and loading from it:
write_xml(doc, "temp.xml")
doc <- read_xml('temp.xml')

# using same query again, results 2:
xml_find_all(doc, xpath)
# the results are correct and link is found

The bug is related to namespaces. If the added child node and query doesn't have xxx: namespace, the output is correct, and results 1 contain the node that was added.
@hadley
Copy link
Member
hadley commented Feb 28, 2022

Looks like this works if you manually specify the namespace when setting the attribute; I suspect xml_add_child isn't correctly passing the ns info around.

library(xml2)
doc <- read_xml('<?xml version="1.0" encoding="UTF-8"?><bookstore xmlns:xxx="https://www.w3.org/"><book name="Harry Potter 1"></book></bookstore>')
xml_ns(doc)
#> xxx <-> https://www.w3.org/

node <- xml_find_first(doc, "book")
link <- xml_add_child(node, .value = "link")
xml_set_attr(link, "xxx:resource", "http://harry_potter.com", ns = xml_ns(doc))

xml_find_all(doc, "//link[@xxx:resource=\"http://harry_potter.com\"]")
#> {xml_nodeset (1)}
#> [1] <link xxx:resource="http://harry_potter.com"/>

Created on 2022-02-28 by the reprex package (v2.0.1)

@hadley hadley added the bug an unexpected problem or unintended behavior label Feb 28, 2022
@cole-johanson cole-johanson mentioned this issue Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @ostroganov
0