8000 Add services into messages_history table · Issue #7181 · rucio/rucio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add services into messages_history table #7181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yuyiguo opened this issue Nov 23, 2024 · 0 comments · Fixed by #7193
Closed

Add services into messages_history table #7181

yuyiguo opened this issue Nov 23, 2024 · 0 comments · Fixed by #7193
Assignees
@Thysk
Labels
enhancement good first issue Messaging
Milestone
37.0.0

Comments

@yuyiguo
Copy link
Contributor
yuyiguo commented Nov 23, 2024

Description

Both messages and messages_history tables have a services column. However, when the a message is copied into messages_history , services info is removed. Please add services into the history table.

Motivation

When debugging with a lot of messages, it will be very helpful to just get the messages that in the services under investigation.

Change

  1. The code is at

    rucio/lib/rucio/daemons/hermes/hermes.py

    Lines 713 to 720 in 488948f

    to_delete = [
    {
    "id": message["id"],
    "created_at": message["created_at"],
    "updated_at": message["created_at"],
    "payload": str(message["payload"]),
    "event_type": message["event_type"],
    }
  2. update code as :
to_delete = [
        {
            "id": message["id"],
            "created_at": message["created_at"],
            "updated_at": message["created_at"],
            "payload": str(message["payload"]),
            "event_type": message["event_type"],
            "services": message["services"], 
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thysk Thysk

Labels
enhancement good first issue Messaging
Projects
No open projects
Rucio 37 “Dungeons & Donkeys” release roadmap
Status: Done
Milestone
37.0.0
Development

Successfully merging a pull request may close this issue.

hermes: preserve services from messages to messages_history #7181 Thysk/rucio
4 participants
@bari12 @yuyiguo @Thysk @rdimaio
0