8000 Document or improve global-pool's auto termination · Issue #227 · ruby-concurrency/concurrent-ruby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Document or improve global-pool's auto termination #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitr-ch opened this issue Jan 16, 2015 · 3 comments
Closed

Document or improve global-pool's auto termination #227

pitr-ch opened this issue Jan 16, 2015 · 3 comments
Assignees
@jdantonio
Labels
bug A bug in the library or documentation.
Milestone
0.9.0

Comments

@pitr-ch
Copy link
Member
pitr-ch commented Jan 16, 2015

If concurrent-ruby is used in tests of other project, the thread pools are terminated before the tests are executed. Reason is the order of at_exit callbacks, termination runs before the test run is executed.
@pitr-ch pitr-ch added the bug A bug in the library or documentation. label Jan 16, 2015
@pitr-ch pitr-ch added this to the 0.7.2 Release milestone Jan 16, 2015
@rkday
Copy link
Contributor
rkday commented Jan 18, 2015

This was part of my motivation for #199 - I hit exactly this with minitest/autorun, and it's much easier to spot if you get an exception by default.

It's easy to work around by setting Concurrent.configuration.auto_terminate = false in a minitest_helper.rb file.

@jdantonio jdantonio modified the milestones: 0.9.0 Release, 0.7.2 Release Jan 25, 2015
@pitr-ch pitr-ch mentioned this issue Feb 21, 2015
Closed
@pitr-ch
Copy link
Member Author
pitr-ch commented Feb 21, 2015

the solution is partly also discussed in #248

@jdantonio jdantonio mentioned this issue Feb 27, 2015
Merged
27 tasks
@jdantonio jdantonio self-assigned this Feb 27, 2015
@jdantonio jdantonio modified the milestones: 0.8.1Release, 0.9.0 Release Feb 27, 2015
@jdantonio jdantonio mentioned this issue Mar 1, 2015
Closed
34 tasks
@jdantonio jdantonio modified the milestones: 0.9.0 Release, 0.8.1Release Mar 1, 2015
@jdantonio
Copy link
Member

Addressed in PR #255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdantonio jdantonio

Labels
bug A bug in the library or documentation.
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@jdantonio @pitr-ch @rkday
0