8000 Use of private module `serde_macros` makes builds fail since 0.9.1 · Issue #101 · rust-bitcoin/bitcoin_hashes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Use of private module serde_macros makes builds fail since 0.9.1 #101

Closed
afilini opened this issue Oct 18, 2020 · 4 comments
Closed

Use of private module serde_macros makes builds fail since 0.9.1 #101

afilini opened this issue Oct 18, 2020 · 4 comments

Comments

@afilini
Copy link
afilini commented Oct 18, 2020

I'm still investigating this, so I'm not entirely sure whether this is our fault in bdk or if this is due to bitcoin_hashes.

Anyways, it looks like the newly-released 0.9.1 makes bdk builds fail with an error regarding the use of private modules somewhere in bitcoin_hashes (see attached log).

This was not happening with 0.9.0 and build trees that still have a cached 0.9.0 copy of bitcoin_hashes will still happily compile. Running cargo update and forcing the update of bitcoin_hashes in those trees to the new release will then make the build fail.

It should be noted that we don't directly import bitcoin_hashes as a dependency, but we depend on it indirectly through bitcoin 0.25.

Issue in our repo: bitcoindevkit/bdk#136

error[E0603]: module `serde_macros` is private
  --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/serde_macros.rs:98:22
   |
98 |         impl $crate::serde_macros::serde_details::SerdeHash for $t {
   |                      ^^^^^^^^^^^^ private module
   |
note: the module `serde_macros` is defined here
  --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/lib.rs:47:14
   |
47 | #[macro_use] mod serde_macros;
   |              ^^^^^^^^^^^^^^^^^

error[E0603]: module `serde_macros` is private
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/serde_macros.rs:107:25
    |
107 |                 $crate::serde_macros::serde_details::SerdeHash::serialize(self, s)
    |                         ^^^^^^^^^^^^ private module
    |
note: the module `serde_macros` is defined here
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/lib.rs:47:14
    |
47  | #[macro_use] mod serde_macros;
    |              ^^^^^^^^^^^^^^^^^

error[E0603]: module `serde_macros` is private
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/serde_macros.rs:113:25
    |
113 |                 $crate::serde_macros::serde_details::SerdeHash::deserialize(d)
    |                         ^^^^^^^^^^^^ private module
    |
note: the module `serde_macros` is defined here
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin_hashes-0.9.1/src/lib.rs:47:14
    |
47  | #[macro_use] mod serde_macros;
    |              ^^^^^^^^^^^^^^^^^

error: aborting due to 3 previous errors
@afilini afilini changed the title Use of private module serde_macro makes builds fail since 0.9.1 Use of private module serde_macros makes builds fail since 0.9.1 Oct 18, 2020
@jrawsthorne
Copy link

rust-bitcoin/rust-bitcoin#502 (comment)

@elichai
Copy link
Member
elichai commented Oct 18, 2020

@afilini Can you please test that this is fixed by #100 ?

@afilini
Copy link
Author
afilini commented Oct 18, 2020 •
edited
Loading

Yes, adding that branch as a patch to our Cargo.toml fixes the issue.

Sorry for the trouble, I forgot to check in the pull requests section and only checked if there was already another issue open for the same problem.

@apoelstra
Copy link
Member

Sorry for letting this sit all weekend. Published 0.9.2 and yanked 0.9.1. Should be good now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrawsthorne @apoelstra @elichai @afilini
0