Support multiword aliases as check commands #19770

mi2ebi · 2025-05-09T05:10:45Z

mi2ebi
May 9, 2025

I have this alias in ~/.cargo/config.toml:

[alias]
nitpick = """clippy --
  -W clippy::pedantic
  -A clippy::must_use_candidate
  -W clippy::nursery
  -A clippy::cognitive_complexity
  -A clippy::missing_const_for_fn
  -W clippy::decimal_literal_representation
  -W clippy::deref_by_slicing
  -W clippy::if_then_some_else_none
  -W clippy::lossy_float_literal
  -W clippy::missing_asserts_for_indexing
  -W clippy::needless_raw_strings
  -W clippy::precedence_bits
  -W clippy::print_stderr
  -W clippy::rest_pat_in_fully_bound_structs
  -W clippy::same_name_method
  -W clippy::semicolon_inside_block
  -W clippy::unused_trait_names
"""

and these Helix settings:

[[language]]
name = "rust"
scope = "source.rust"
roots = ["Cargo.toml", "cargo.lock"]
language-servers = ["rust-analyzer"]
auto-format = true

[language-server.rust-analyzer.config]
check = {command = "nitpick"}
cargo = {features = "all"}

Running cargo nitpick myself on a file like

fn main() {
    println!("Hello, world!");
    let b = if true { 1 } else { 0 };
}

correctly outputs

warning: unused variable: `b`
 --> src/main.rs:3:9
  |
3 |     let b = if true { 1 } else { 0 };
  |         ^ help: if this is intentional, prefix it with an underscore: `_b`
  |
  = note: `#[warn(unused_variables)]` on by default

warning: boolean to int conversion using if
 --> src/main.rs:3:13
  |
3 |     let b = if true { 1 } else { 0 };
  |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `i32::from(true)`
  |
  = note: `true as i32` or `true.into()` can also be valid options
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if
  = note: `-W clippy::bool-to-int-with-if` implied by `-W clippy::pedantic`
  = help: to override `-W clippy::pedantic` add `#[allow(clippy::bool_to_int_with_if)]`

But when Helix tries to run rust-analyzer's check, it says (followed by some other stuff that doesn't fit)

Cargo check failed to start: Cargo watcher failed, the command produced no valid metadata (exit code: ExitStatus(unix_wait_status(25856))

lnicola · 2025-05-09T05:17:42Z

lnicola
May 9, 2025
Collaborator

Hmm, I get an error because we're passing --workspace, and if I disable that, I get error: Unrecognized option: 'p' (because we run cargo nitpick -p blah --bin blah.

0 replies

lnicola · 2025-05-09T05:24:33Z

lnicola
May 9, 2025
Collaborator

You can try

[alias]
nitpick = """clippy --message-format=json-diagnostic-rendered-ansi --
  -W clippy::pedantic
  -A clippy::must_use_candidate
  -W clippy::nursery
  -A clippy::cognitive_complexity
  -A clippy::missing_const_for_fn
  -W clippy::decimal_literal_representation
  -W clippy::deref_by_slicing
  -W clippy::if_then_some_else_none
  -W clippy::lossy_float_literal
  -W clippy::missing_asserts_for_indexing
  -W clippy::needless_raw_strings
  -W clippy::precedence_bits
  -W clippy::print_stderr
  -W clippy::rest_pat_in_fully_bound_structs
  -W clippy::same_name_method
  -W clippy::semicolon_inside_block
  -W clippy::unused_trait_names
"""

with rust-analyzer.check.overrideCommand set to ["cargo", "nitpick"]. It's the same problem with -p and --workspace: you want cargo clippy --workspace ... -- -W ..., but cargo nitpick --worspace sticks it at the end, with the warnings.

For a better solution, see https://doc.rust-lang.org/stable/cargo/reference/manifest.html#the-lints-section.

0 replies

mi2ebi · 2025-05-09T05:43:46Z

mi2ebi
May 9, 2025
Author

This worked, thank you, other than that I do want manually running cargo nitpick to give me fancy colored stuff rather than a json if possible

0 replies

lnicola · 2025-05-09T05:45:09Z

lnicola
May 9, 2025
Collaborator

You can configure the lints in the manifest, then just run clippy.

0 replies

mi2ebi · 2025-05-09T05:48:37Z

mi2ebi
May 9, 2025
Author

Aren't manifests local to crates? The point of me defining nitpick was not wanting to have to do that

0 replies

lnicola · 2025-05-09T06:02:05Z

lnicola
May 9, 2025
Collaborator

They are. But having to override the full command in r-a isn't ideal either. I'd write a script that calls cargo clippy "$@" -- -W blah ..., then use that instead of a cargo alias.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support multiword aliases as check commands #19770

Uh oh!

{{title}}

Uh oh!

Replies: 6 comments

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Support multiword aliases as check commands #19770

Uh oh!

mi2ebi May 9, 2025

Replies: 6 comments

Uh oh!

lnicola May 9, 2025 Collaborator

Uh oh!

lnicola May 9, 2025 Collaborator

Uh oh!

mi2ebi May 9, 2025 Author

Uh oh!

lnicola May 9, 2025 Collaborator

Uh oh!

mi2ebi May 9, 2025 Author

Uh oh!

lnicola May 9, 2025 Collaborator

mi2ebi
May 9, 2025

lnicola
May 9, 2025
Collaborator

lnicola
May 9, 2025
Collaborator

mi2ebi
May 9, 2025
Author

lnicola
May 9, 2025
Collaborator

mi2ebi
May 9, 2025
Author

lnicola
May 9, 2025
Collaborator