8000 OnChange no longer assigns to existing data · Issue #1278 · react-page/react-page · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
OnChange no longer assigns to existing data #1278
Closed
@PeterKottas

Description

@PeterKottas

Describe the bug
When updating to the latest version (v5.4.1) I noticed that calling OnChange inside a plugin no longer assigns to existing data, it replaces them. This breaks some of the existing plugins. Not sure when this was introduced though.

To Reproduce
Steps to reproduce the behavior:
Go to https://react-page.github.io/ and play with the background plugin. Once you change anything, the data disappears and it only holds the latest change.

Expected behavior
I believe it should map onto existing data, if anything changed and is documented, we should probably at least fix the demo.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: ALL
  • Browser ALL
  • Version v5.4.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0