8000 File tree diff: show diff from when the PR was opened · Issue #12232 · readthedocs/readthedocs.org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
File tree diff: show diff from when the PR was opened #12232
Open
@stsewd

Description

@stsewd

What's the problem this feature will solve?

Currently, we get the diff using the current state of the latest version, this works great when the PR is recently opened, but it becomes a problem after latest gets updated, showing several files marked as changed that the PR didn't actually change.

This is more noticeable in repos that move fast, or PRs that are not frequently updated.

Describe the solution you'd like

We should calculate the diff based on the moment the PR was opened, maybe even try to match the diff from the commit that the base branch is based on. When the PR is updated, we re-calculate the diff, maybe show a little note to the use letting them know that the diff is from a previous state of latest.

This is also a problem with visual diff, as it also highlights the changes using the current version of latest, maybe we could store the visual diff results as well instead of doing it dynamically.

Alternative solutions

None.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0