Open
Description
The diff filtering feature of reviewdog does not work correctly under the following conditions:
- The input format is SARIF (
-f sarif). - The current working directory is a subdirectory within a git project.
Due to this, github-* reporters remain silent for SARIF inputs. I encountered this issue while investigating reviewdog/action-trivy#74.
It appears that the issue arises because the SARIF parser and the rest of the codebase interpret relative paths differently. The SARIF parser in reviewdog creates Diagnostics with file locations relative to the git root. However, the rest of the codebase treats file locations within Diagnostics as relative to the current working directory.
Lines 35 to 37 in fd59714
Line 84 in bee2aee
Metadata
Metadata
Assignees
Labels
No labels