-
Notifications
You must be signed in to change notification settings - Fork 40
Can't find newlines (\n) when regex find isn't enabled #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've been thinking about this, and UX wise it's not entirely simple. When the user uses the non-regex find, we don't know wether they wan't to use escape sequences like Should we actually just constrain escape sequences to regex search? Now the prompts only support single line input (simple to accept with enter), so inserting an actual new line into the search prompt can't be done if multi line prompts aren't implemented. Anyway, if escape sequences are to be interpreted I'd probably go with this: http://stackoverflow.com/questions/4020539/process-escape-sequences-in-a-string-in-python |
Multi line prompts would be nice to have. Only problem is there's no support for "shift-enter" in the termimal :/ |
Damn, is that something that could be fixed by moving to raw mode? |
I wish it helped. We should be in raw mode already https://github.com/richrd/suplemon/blob/master/suplemon/ui.py#L120 Anyway I do think a multi line prompt could be something worth having, but maybe it's not worth it just for this usecase. |
Ah, I think I missed that transition. I concur with your work to value assessment and maybe there's another solution |
For now I'll keep the behaviour as it is. For regex searches it makes perfect sense for |
Let me backtrack a little regarding |
New lines should be findable in all modes.
The text was updated successfully, but these errors were encountered: