8000 test: extended query mode / 3rd-party tools are not well tested · Issue #14141 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
test: extended query mode / 3rd-party tools are not well tested #14141
Closed as not planned
@BugenZhao

Description

@BugenZhao

Recently there was a regression (#14102) for not being able to connect RisingWave with 3rd-party tools, which primarily relies on the extended query mode. Despite the timely release of the quick fix in v1.5.2, we still didn't conduct any testing on it. As a result, it could be easily broken again in the future (#14105 (review)).

As shown in e2e_test/extended_mode, very limited cases are tested with extended mode.

include ../batch/types/boolean.slt.part
include ../batch/types/cast.slt.part
include ../batch/types/date.slt
include ../batch/types/intercal.slt.part
include ../batch/types/number_arithmetic.slt.part
include ../batch/types/temporal_arithmetic.slt.part
include ../batch/types/time.slt.part
include ../batch/types/timestamptz_utc.slt.part

I would suggest adding more tests for extended mode query by focusing on the real cases. Possible approaches:

  • Integrate 3rd-party tools in CI and emulate some basic operations. For GUI tools, use GUI automation.
  • Manually emulate basic operations with 3rd-party tools, then dump the queries into a sqllogictest case.
    However, it's worth noting that sqllogictest-rs does not have full support on postgres extended mode: only prepare and query is covered. Improvements need to be made to support parse, bind, execute, describe and so on.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-frontendArea: Protocol, parsing, binder.A-testArea: Testing framework & misc tests not belonging to any specific component.no-issue-activitytype/enhancementType: Enhancement for an existing feature.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0