8000 Reject FORMAT ENCODE options in WITH options · Issue #15824 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reject FORMAT ENCODE options in WITH options #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xxchan opened this issue Mar 20, 2024 · 1 comment
Open

Reject FORMAT ENCODE options in WITH options #15824

xxchan opened this issue Mar 20, 2024 · 1 comment
Assignees
@tabVersion
Labels
type/feature Type: New feature.
Milestone
release-2.5

Comments

@xxchan
Copy link
Member
xxchan commented Mar 20, 2024

e.g.,

CREATE SINK ...
WITH (
    ...
    timestamptz.handling.mode='utc_without_suffix'
) FORMAT UPSERT ENCODE JSON;

This will succeed, but utc_without_suffix doesn't work.
The correct version is

CREATE SINK ...
WITH (
    ...
) FORMAT UPSERT ENCODE JSON (
	timestamptz.handling.mode='utc_without_suffix'
);

We should reject the wrong version, instead of accepting it silently.
@xxchan xxchan added the type/feature Type: New feature. label Mar 20, 2024
@github-actions github-actions bot added this to the release-1.8 milestone Mar 20, 2024
@xxchan
Copy link
Member Author
xxchan commented Mar 20, 2024

I think after #13762, the frontend's behavior changed, but

  • we didn't reject it in frontend
  • doc might also need to highlight the difference

@fuyufjh fuyufjh modified the milestones: release-1.8, release-1.9 Apr 8, 2024
@tabVersion tabVersion modified the milestones: release-1.9, release-1.10 May 14, 2024
@BugenZhao BugenZhao modified the milestones: release-2.4, release-2.5 May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabVersion tabVersion

Labels
type/feature Type: New feature.
Projects
None yet
Milestone
release-2.5
Development

No branches or pull requests
4 participants
@fuyufjh @tabVersion @BugenZhao @xxchan
0