8000 bug(sink): json encoder does not preserve microsecond precision · Issue #13564 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bug(sink): json encoder does not preserve microsecond precision #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xiangjinwu opened this issue Nov 21, 2023 · 4 comments
Open

bug(sink): json encoder does not preserve microsecond precision #13564

xiangjinwu opened this issue Nov 21, 2023 · 4 comments
Assignees
@xiangjinwu
Labels
A-connector Area: Connector. type/bug Type: Bug. Only for issues.
Milestone
release-2.5

Comments

@xiangjinwu
Copy link
Contributor

No description provided.

@xiangjinwu xiangjinwu added the type/feature Type: New feature. label Nov 21, 2023
@github-actions github-actions bot added this to the release-1.5 milestone Nov 21, 2023
@xuefengze xuefengze mentioned this issue Nov 23, 2023
Merged
9 tasks
@xuefengze
Copy link
Contributor

It seems that the time type ignores the millisecond part in json encoder?

@xiangjinwu
Copy link
Contributor Author

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

@tabVersion
Copy link
Contributor

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

Can we resue the same options as the json parser in source?

@xiangjinwu
Copy link
Contributor Author

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

Can we resue the same options as the json parser in source?

Yes for the enum definition

risingwave/src/connector/src/parser/unified/json.rs

Lines 41 to 45 in 14ff124

#[derive(Clone, Debug)]
pub enum TimeHandling {
Milli,
Micro,
}

Additionally it may need to be exposed as a format option #13109

@xiangjinwu xiangjinwu added A-connector Area: Connector. type/bug Type: Bug. Only for issues. and removed type/feature Type: New feature. labels Nov 30, 2023
@xiangjinwu xiangjinwu self-assigned this Dec 6, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.5, release-1.6 Dec 6, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.8, release-1.9 Apr 8, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.9, release-1.10 May 13, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@xiangjinwu xiangjinwu modified the milestones: release-2.1, release-2.2 Oct 17, 2024
@xiangjinwu xiangjinwu modified the milestones: release-2.2, release-2.3 Jan 8, 2025
@xiangjinwu xiangjinwu removed this from the release-2.3 milestone Apr 25, 2025
@xiangjinwu xiangjinwu added this to the release-2.4 milestone Apr 25, 2025
@BugenZhao BugenZhao modified the milestones: release-2.4, release-2.5 May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangjinwu xiangjinwu

Labels
A-connector Area: Connector. type/bug Type: Bug. Only for issues.
3DCB
Projects
None yet
Milestone
release-2.5
Development

No branches or pull requests
4 participants
@tabVersion @xiangjinwu @BugenZhao @xuefengze
0