8000 State cleaning in general streaming over window executor · Issue #13907 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

State cleaning in general streaming over window executor #13907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #9124
stdrc opened this issue Dec 11, 2023 · 2 comments
Open
Tracked by #9124

State cleaning in general streaming over window executor #13907

stdrc opened this issue Dec 11, 2023 · 2 comments
Assignees
Labels
A-watermark A-window-func Area: Window function, OverWindow. no-issue-activity type/perf Type: Performance.

Comments

@stdrc
Copy link
Member
stdrc commented Dec 11, 2023

Currently watermark messages are not handled by general version of streaming OverWindowExecutor. It's reported that the state of OverWindow eventually becoming too large. We may need to add state cleaning by watermark for it. Unlike interval join that knows every rows to cleanup, OverWindow only caches a range of rows in cache, so it may only be able to clean state in the same way HashAgg does, which means it can only clean state with watermarks on PARTITION BY columns.

OTOH for EOWC version, state cleaning is implemented by design.

@stdrc stdrc added the type/perf Type: Performance. label Dec 11, 2023
@github-actions github-actions bot added this to the release-1.6 milestone Dec 11, 2023
@fuyufjh fuyufjh modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@stdrc stdrc removed this from the release-1.9 milestone May 10, 2024
@stdrc
Copy link
Member Author
stdrc commented May 10, 2024

This is slightly related to #13908, both need to handle watermark on PARTITION BY columns.

Copy link
Contributor
github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@stdrc stdrc added A-window-func Area: Window function, OverWindow. A-watermark labels May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-watermark A-window-func Area: Window function, OverWindow. no-issue-activity type/perf Type: Performance.
Projects
None yet
Development

No branches or pull requests

2 participants
0