8000 [Feature Request] Dispose method for cleaning up the three.js renderer inside the Hover Effect in SPA · Issue #50 · robin-dela/hover-effect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature Request] Dispose method for cleaning up the three.js renderer inside the Hover Effect in SPA #50

New issue
921B

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
snowiewdev opened this issue Jun 28, 2022 · 0 comments
Open

[Feature Request] Dispose method for cleaning up the three.js renderer inside the Hover Effect in SPA #50

snowiewdev opened this issue Jun 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@snowiewdev
Copy link

Hi there, thanks for building this amazing library for us to use. I would like to request for the dispose() / clean() method inside the HoverEffect for cleaning up the three.js renderer before unmount in SPA, because the hoverEffect won't get destroyed in single page application, which creates the renderer only and leaves out a number of the webGL content, thus the warning in the console.
Something like...

var hoverEffect = new HoverEffect({...});
hoverEffect.dispose();  // <- we can then call this in beforeDestroy / before unmount phase

would be really helpful. Thanks a lot.
@robin-dela robin-dela added the enhancement New feature or request label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robin-dela @snowiewdev
0