Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Co 8000 mparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 53 files changed
- 2 contributors
Commits on Oct 24, 2018
-
This uses the new testing framework from go/packages, but does not actually use go/packages itself. These tests are intended to check the basic functionality of godef, and should remain stable across the implementation change to come.
Commits on Oct 25, 2018
Commits on Nov 13, 2018
-
We add some more tests, including two failing tests, one of which is fixed (it now doesn't ignore the in-editor version of the buffer). Also fix the go tools dependency so it refers to a working version of the tools module that's not after the breaking change made to the `contains:` pattern. The issue that still needs to be fixed is that if you jump to the definition of an embedded field from that field itself, it should go to the type referred to rather than going to the same place. Still needed: a test that godef on an import path will print the directory containing the imported package. I'm not sure whether to stay within the packagestest Expect framework for that one.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...001-more-tests