8000 Java RMI: handling of null arguments in remote API · Issue #55 · rolandweber/Pityoulish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 21, 2021. It is now read-only.

Java RMI: handling of null arguments in remote API #55

Open
rolandweber opened this issue Aug 17, 2017 · 0 comments
Open

Java RMI: handling of null arguments in remote API #55

rolandweber opened this issue Aug 17, 2017 · 0 comments
Labels
Coding effort medium help wanted

Comments

@rolandweber
Copy link
Owner

follow-up from #11:

  • Should null arguments be reported as an ApiException or as a NullPointerException (NPE)?
  • Should the exception be logged?

Currently, the sanity checkers throw an NPE, which is not logged. But RemoteOutletManagerImpl.publishOutlet logs the NPE for a null outlet. So that method throws a logged NPE if the outlet is null, but an unlogged NPE if the ticket token is null. Decide on one behavior, then implement that consistently across the remote API of the server.

If the behavior of the sanity checkers changes, this will affect the Socket-based server, too.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Coding effort medium help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolandweber
0