8000 Should suppress header info · Issue #2 · ropensci/unrtf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Should suppress header info #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kbenoit opened this issue Jun 9, 2017 · 6 comments
Open

Should suppress header info #2

kbenoit opened this issue Jun 9, 2017 · 6 comments

Comments

@kbenoit
Copy link
kbenoit commented Jun 9, 2017 •
edited
Loading

I see no need to include the header info in the output, so either disable by default or make this an argument. Similar to

unrtf --text --quiet thefile.rtf

Ideally the output would not include any meta-information.

Note: These can be set in the .conf files.
@jeroen
Copy link
Member
jeroen commented Jun 9, 2017 •
edited
Loading

Edit: hmmm I can't get --quiet to work. At least it keeps printing header info. Does that work for you?

We can add an option to specify the conf files if that's helpful.

@jeroen
Copy link
Member
jeroen commented Jun 9, 2017

@kbenoit I added a parameter conf_dir can you test this? I can't find the --quiet option that you mention.

@kbenoit
Copy link
Author
kbenoit commented Jun 10, 2017

I'm not sure the ability to specify conf files will be interesting or comprehensible to most users... Here's the behaviours I'm getting with the command line options. All still have the header info, which is defined in the text.conf file. I'd suggest overwriting that to turn off the header info and font messages etc by default. If it's needed to be output, it could be a verbose = TRUE` call to the R function, and be printed as a console message rather than embedded in the file.

KBsMBP15:quanteda kbenoit$ unrtf --text ~/Downloads/Hungarian.rtf 
###  Translation from RTF performed by UnRTF, version 0.21.9 
### font table contains 0 fonts total
### invalid font number 0

-----------------
Nem tudjuk, mikor kezddhetnek meg Nagy-Britanni?val a kil?p?si t?rgyal?sok, csak azt, mikor kell befejezdni?k - k?z?lte Donald Tusk, az Eur?pai Tan?cs eln?ke.?Jean-Claude Juncker, az Eur?pai Bizotts?g eln?ke b?zik abban, hogy a brit parlamenti v?laszt?sok eredm?nye nem lesz hat?ssal a Brexitrl sz?l? t?rgyal?sokra, ?gy azok min?l hamarabb megkezddnek Nagy-Britannia az Eur?pai Uni? k?z?tt. A n?met k?l?gyminiszter szerint a brit v?laszt?s eredm?nye a Brexit elutas?t?s?t t?kr?zi.?

KBsMBP15:quanteda kbenoit$ unrtf --text --quiet ~/Downloads/Hungarian.rtf 
###  Translation from RTF performed by UnRTF, version 0.21.9 
### font table contains 0 fonts total
### invalid font number 0

-----------------
Nem tudjuk, mikor kezddhetnek meg Nagy-Britanni?val a kil?p?si t?rgyal?sok, csak azt, mikor kell befejezdni?k - k?z?lte Donald Tusk, az Eur?pai Tan?cs eln?ke.?Jean-Claude Juncker, az Eur?pai Bizotts?g eln?ke b?zik abban, hogy a brit parlamenti v?laszt?sok eredm?nye nem lesz hat?ssal a Brexitrl sz?l? t?rgyal?sokra, ?gy azok min?l hamarabb megkezddnek Nagy-Britannia az Eur?pai Uni? k?z?tt. A n?met k?l?gyminiszter szerint a brit v?laszt?s eredm?nye a Brexit elutas?t?s?t t?kr?zi.?

KBsMBP15:quanteda kbenoit$ unrtf --text --verbose  ~/Downloads/Hungarian.rtf 
This is UnRTF version 0.21.9
By Dave Davey, Marcos Serrou do Amaral and Arkadiusz Firus
Original Author: Zachary Smith
show_dirs: 1 directories
directory = /usr/local/Cellar/unrtf/0.21.9/share/unrtf/
Processing /Users/kbenoit/Downloads/Hungarian.rtf...
###  Translation from RTF performed by UnRTF, version 0.21.9 
### font table contains 0 fonts total
### invalid font number 0

-----------------
Nem tudjuk, mikor kezddhetnek meg Nagy-Britanni?val a kil?p?si t?rgyal?sok, csak azt, mikor kell befejezdni?k - k?z?lte Donald Tusk, az Eur?pai Tan?cs eln?ke.?Jean-Claude Juncker, az Eur?pai Bizotts?g eln?ke b?zik abban, hogy a brit parlamenti v?laszt?sok eredm?nye nem lesz hat?ssal a Brexitrl sz?l? t?rgyal?sokra, ?gy azok min?l hamarabb megkezddnek Nagy-Britannia az Eur?pai Uni? k?z?tt. A n?met k?l?gyminiszter szerint a brit v?laszt?s eredm?nye a Brexit elutas?t?s?t t?kr?zi.?
Done.
127 words were hashed.

@jeroen
Copy link
Member
jeroen commented Jun 10, 2017

How do I turn that off by default? Want to have a look and do a PR?

@kbenoit
Copy link
Author
kbenoit commented Jun 10, 2017

Happy to do that. I'll add more test files locally too. Might be a few days but I'll get to it soon.

@jeroen
Copy link
Member
jeroen commented Jun 10, 2017

OK I'll push a version to CRAN now and then we can do a follow up release next week.

This was referenced Nov 21, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeroen @kbenoit
0