8000 add specialised inverse cdf implementation for geometric distribution by nataziel · Pull Request #343 · statrs-dev/statrs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add specialised inverse cdf implementation for geometric distribution #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add specialised inverse cdf implementation for geometric distribution #343

wants to merge 1 commit into from

Conversation

nataziel
Copy link

closes #342

@nataziel
Copy link
Author

@YeungOnion would you mind taking a look at this?

@YeungOnion
Copy link
Contributor

Thanks for the ping and for contributing!

Would you be able to write a few tests, specifically for
small p (2e-16) with x near 1, maybe 1-1e-15? Just wanting to know if there should be a warning output for small p regarding an upper bound to k, and if so, at what range of p.

Since the domain of CDF is natural numbers but the type is u64, want to ensure the inversion property is upheld for the range of values in u64.

Does my request seem justified?

@codecov Codecov
Copy link
codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.99%. Comparing base (526e85e) to head (edcbcab).

Files with missing lines Patch % Lines
src/distribution/geometric.rs 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   95.01%   94.99%   -0.02%     
==========================================
  Files          60       60              
  Lines       13
8000
529    13539      +10     
==========================================
+ Hits        12854    12862       +8     
- Misses        675      677       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YeungOnion
Copy link
Contributor

Let me know if you need any clarity on the request.

@nataziel
Copy link
Author

Request is fine, just need to find time to implement! Will try this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Succ 3CDF essfully merging this pull request may close these issues.

issue in default inverse_cdf, found with simple case of Geometric
2 participants
@nataziel @YeungOnion
0