8000 fix(ssr): named slot dom order with `serializeShadowRoot: 'scoped'` components by johnjenkins · Pull Request #6300 · stenciljs/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ssr): named slot dom order with serializeShadowRoot: 'scoped' components #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

fix(ssr): named slot dom order with serializeShadowRoot: 'scoped' components #6300

merged 5 commits into from
Jun 17, 2025

Conversation

johnjenkins
Copy link
Contributor

What is the current behavior?

GitHub Issue Number: #6299

What is the new behavior?

Fixes #6299

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@johnjenkins johnjenkins requested a review from a team as a code owner June 14, 2025 00:43
@johnjenkins johnjenkins marked this pull request as draft June 14, 2025 00:45
@johnjenkins johnjenkins marked this pull request as ready for review June 16, 2025 21:48
christian-bromann
christian-bromann approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member
@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johnjenkins johnjenkins added this pull request to the merge queue Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2025
@christian-bromann christian-bromann merged commit 96c0f13 into main Jun 17, 2025
72 checks passed
@christian-bromann christian-bromann deleted the ssr-scoped-named-slot-order branch June 17, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: incorrect named slot dom order with serializeShadowRoot: 'scoped' components
2 participants
@johnjenkins @christian-bromann
0