8000 Complete list of MELPA blockers · Issue #65 · sunrise-commander/sunrise-commander · GitHub 10000
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Complete list of MELPA blockers #65
Open
@lassik

Description

@lassik

List of all previous MELPA/ELPA issues in this repo

Why SC was removed from MELPA

SC was added to MELPA in 2012: melpa/melpa#153

But removed in 2013: melpa/melpa#602

Relevant remarks from the removal thread:

the extension source files are not currently set up correctly for packaging. Each one should have have a dependency line similar to ;; Package-Requires: ((sunrise-commander "6")) in its comment header.

You might consider filing a pull request with the sunrise-commander project to add these headers, or (strongly preferable) suggest that the author provide a way to disable extensions even when they are available.

I've looked at the sunrise-commander source code, and I can't see any code which automatically loads the extensions if present. In fact, the doc headers for the extensions say that they should be explicitly required in order to enable them.

the code is in the extensions, except the ...-checkpoints extensions all have a magic autoload comment at the end.

the options are either:

  • Remove those autoload lines (preferred solution) or...
  • Add Package-Requires headers to all the extensions

The sr-extend-with function should be responsible for trying to load the extensions .el for the given name. It's fine to package all the extension but the author should meet us halfway and remove the autoloads.

It is not too weird to have a an extensible plugin include a default set of plugins. Yasnippet includes a default set of snippets. We don't package them separately.

Conflicting extensions used to be installed by the bundle in MELPA

Well, actually that looks like a problem with the bundle installed by MELPA: it seems it's installing two extensions that are not totally compatible with each other: the popviewer extension (that makes the viewer window "pop up" in a separate frame) and the buttons extension. I would recommend at least for a start to disable one of them doing M-x customize-variable [RET] sr-popviewer-enabled [RET] and toggling that flag off. In the long run, I'm planning to fix that small incompatibility between the two extensions, so you can have them both installed simultaneously without seeing weird effects like that.

Additionally, since MELPA has changed somewhat the rules of the game (by making all extensions, which were supposed to be optional, the default) I've changed the default value of the sr-popviewer-enabled flag to false in order to make the choice between regular and popped viewer apparent to new users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0