8000 Feature request - hiding of viewer pane · Issue #107 · sunrise-commander/sunrise-commander · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature request - hiding of viewer pane #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dadinn opened this issue Dec 15, 2020 · 3 comments
Open

Feature request - hiding of viewer pane #107

dadinn opened this issue Dec 15, 2020 · 3 comments

Comments

@dadinn
Copy link
dadinn commented Dec 15, 2020 •
edited
Loading

Problem

I have been using sunrise-commander for a long time. One of my frustrations with the default setup is that I usually don't want to see the viewer pane, as I rarely use the feature, and I prefer to have the whole screen for the two main panes.

There is the popviewer extension, which though hides the viewer pane, it goes overboard by opening a new Emacs window for the viewer. I worked around this annoyance by removing all the viewer key-bindings. Unfortunately, this way I would completely loose the viewer functionality.

Environment

OS version: Debian 10
Emacs version: 26.1
Sunrise-commander version: master

Suggestion

My suggestion would be to introduce a customizable boolean variable, so when it is set false, the viewer pane is not shown during sr-setup-windows. Instead the viewer is only displayed when sr-quick-view is pressed. Also, when C-u v (i.e sr-quick-view with universal argument) is pressed, then the viewer pane is hidden again.

Example

I have tried to implement this myself here, but since I have no clue what I am doing, I would appreciate if someone looked at it, as I have likely introduced some bugs too.

Sometimes it seems I am getting weird behaviour, like the panes not closing correctly, when sr-quit is pressed.
Also, I when sr-lock-panes is pressed sr-lock-panes seem to shrink the right pane by 1 line, which I wasn't able figure out why. Actually, I am not sure I understand the purpose of sr-lock-panes, as intuitively I would expect \ to reset the panes to their defaults. Wouldn't it be more appropriate to bind \ to sr-setup-windows instead?

The sr-show-viewer-on-start variable I have introduced is by default true. Unless it is set false, I would expect everything to work just the same as before. Nevertheless, disabling/hiding the viewer possibly affects popviewer, and buttons extensions.
@lassik
Copy link
Contributor
lassik commented Feb 26, 2021

@dadinn Sorry about the long delay in responding. Would you like to help get SR to MELPA? Here are the pending tasks: https://github.com/sunrise-commander/sunrise-commander/milestone/1

@dadinn
Copy link
Author
dadinn commented Mar 28, 2021

@lassik I am quite flooded these days, but when I have some spare time I might be able to.

@dadinn
Copy link
Author
dadinn commented Mar 28, 2021 •
edited
Loading

BTW I am not using MELPA anymore.
I've moved to straight.el, and using sunrise-commender via straight by cloning the git repo directly!
When MELPA dropped sunrise-commander, I first tried el-get.
But since then, I've seen the light!
I'm using NixOS, and Guix now!
My Emacs deserves better too!
TO THE MARS AND BEYOND!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dadinn @lassik
0