feat: Add custom claims from Keycloak user token #1917
Merged
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15463301096Details
💛 - Coveralls |
cstockton
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks okay to me, lets wait for a +1 from @hf or @kangmingtay before merging. I'm not sure the affect this could have on JWT sizes.
|
Hi @hf @kangmingtay @cstockton is there anything I can look at to merge this feature? |
|
This would be useful for a use case that we have. Is there anything I can do to help? |
|
What is the timeline for merging this feature? |
|
@cstockton can we merge this please? |
|
@ion-elgreco @wdoppenberg @dhcsousa My apologies for the delay, I've seen no objections so I'll go ahead and merge this. |
hf
pushed a commit
that referenced
this pull request
Jun 11, 2025
🤖 I have created a release *beep* *boop* --- ## [2.176.0](v2.175.0...v2.176.0) (2025-06-11) ### Features * Add custom claims from Keycloak user token ([#1917](#1917)) ([1365aaa](1365aaa)) ### Bug Fixes * accept ID tokens from all `account.apple.com` and `appleid.apple.com` ([#2050< 73B4 /a>](#2050)) ([82aa167](82aa167)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This change will populate the
CustomClaimsfield from theClaimsstruct with 'other' claims from the Keycloak user token.What is the current behavior?
Currently only
Name,Sub,Email, andEmailVerifiedare taken from the Keycloak user token.What is the new behavior?
The "custom_claims" field in the retrieved JWT is populated.
Additional context