8000 Improve address validation · Issue #1866 · symbol/desktop-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Improve address validation #1866
Open
Open
@cryptoBeliever

Description

@cryptoBeliever

Current behavior

At this moment wallet is not performing full validation (with checksum check) for address on user input e.g:

  • when putting the address on the transfer transaction form (simple and in aggregate)
  • when adding to t 53E9 he address book
  • when creating an invoice

Example invalid addresses:

  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5HAA
  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5AAA
  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DHAAAA

What's the issue?

Because of limited validation, there are often problems on the serialization level where the wallet is unable to create transactions.
For example when I'm using an invalid address (TCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5HAA) and trying to send tx serialization failing:

image

image

Expected behavior

The wallet should validate provided by the user's address strictly with checksum checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0