8000 hts_tpool_process_flush double prototype in header · Issue #816 · samtools/htslib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

hts_tpool_process_flush double prototype in header #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jblachly opened this issue Jan 19, 2019 · 1 comment
Closed

hts_tpool_process_flush double prototype in header #816

jblachly opened this issue Jan 19, 2019 · 1 comment

Comments

@jblachly
Copy link
Contributor

First with slightly better function documentation:

htslib/htslib/thread_pool.h

Lines 134 to 145 in a80f5fd

/*
* Flushes the process-queue, but doesn't exit. This simply drains the queue
* and ensures all worker threads have finished their current tasks
* associated with this process.
*
* NOT: This does not mean the worker threads are not executing jobs in
* another process-queue.
*
* Returns 0 on success;
* -1 on failure
*/
int hts_tpool_process_flush(hts_tpool_process *q);

Second:

htslib/htslib/thread_pool.h

Lines 231 to 239 in a80f5fd

/*
* Flushes the thread pool, but doesn't exit. This simply drains the
* process-queue and ensures all worker threads have finished their current
* task if associated with this process.
*
* Returns 0 on success;
* -1 on failure
*/
int hts_tpool_process_flush(hts_tpool_process *q);

@jkbonfield
Copy link
Contributor

Thanks for the bug report. I'll remove the second copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkbonfield @jblachly
0