Nav categories block is likely to cause bugs when new pages are added #27

brassy-endomorph · 2024-01-26T08:10:54Z

This block:

Lines 72 to 87 in 94cbd71

    
           {% if request.endpoint not in ['login', 'register', 'publish', 'edit_article', 'user_settings', 'team', 'approve_articles', 'users'] %} 
        
               <ul class="categories-list"> 
        
                   {% for scope in all_scopes %} 
        
                       <li> 
        
                           {% if scope.type == 'type' %} 
        
                               <a href="{{ url_for('articles_by_type', article_type=scope.name) }}">{{ scope.name }}</a> 
        
                           {% elif scope.type == 'country' %} 
        
                               <a href="{{ url_for('articles_by_country', country=scope.name) }}">{{ scope.name }}</a> 
        
                           {% elif scope.type == 'source' %} 
        
                               <a href="{{ url_for('articles_by_source', source=scope.name) }}">{{ scope.name }}</a> 
        
                           {% endif %} 
        
                       </li> 
        
                   {% endfor %} 
        
                   <li><a href="{{ url_for('all_categories') }}">All</a></li> 
        
               </ul> 
        
           {% endif %}

Should be moved to its own template that extends from base.html and then the relevant pages should extend from this. Where the div is currently should be an injectable block that defaults to empty

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nav categories block is likely to cause bugs when new pages are added #27

Nav categories block is likely to cause bugs when new pages are added #27

Nav categories block is likely to cause bugs when new pages are added #27

Nav categories block is likely to cause bugs when new pages are added #27

Comments