-
Notifications
You must be signed in to change notification settings - Fork 13
Support External CSS (Example) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi Sean! I've been playing with your library over the week-end and I'd be happy to contribute an example if you think it'd be useful. My working example is here: https://github.com/benjamin-thomas/7guis/tree/063a04d7c3bf00fe230b245a124454a3853d7fbe/haskell/hyperbole/app
Regarding this question (from #97 (comment)), I'm thinking it'd be nice to have an alternative "global import", something like Also, if you're open to examples contributions, it'd be interested in contributing "7 GUI" examples, which I think is an interesting benchmark because it's simple enough not to be a time sink, but complex enough to demonstrate tricky interactions and workflows. Although I've never used vuejs, I've noticed that their doc references the 7 GUI examples (and the traditional todomvc), here: https://vuejs.org/examples/#counter So, it could be a good way to demonstrate what the library can do, and also to demonstrate useful patterns. Either separately from the docs.hyperbole.live site, or integrated into it? I'd expect some examples to require a little bit of javascript to work, which would be interest to show as well. |
It would be great to have your help!
If you'd like to submit a PR for the TodoMVC external CSS example, can you do one that only changes the views, but reuses the existing Effect and HyperViews? I believe only the view functions need to change.
That could work. Alternatively, I could be convinced to flip it on its head and require users to import their own view library of choice. So, something like this?
Then it would be obvious that there are options:
I suppose it depends on how often people will want to opt-out of web-view, but it's come up once before, and philosophically, I'm a fan of composition over big default groups. I DO want to encourage users to try out the atomic CSS approach.
Neat. I hadn't heard of 7 GUI. I read the site and agree those would be both a great source of examples and a benchmark of how complete our support is. I'd love to incorporate them into the existing examples site, but the menu is getting long enough we need to start adding some hierarchy. Go break a leg, I'll figure out how to integrate it into the examples site later. Things to keep in mind
Thanks! |
Are there examples of other projects that have figured out how to deal with imports in a way that makes it easy for users following a golden path but doesn't force it down their throats? |
I opened #101 to separate this thread from the imports issue. let's move all discussion of imports and easy opt-out of web-view there. Let's keep this focused on examples |
Sounds good to me! I'll keep you posted. |
With the new atomic-css release, External classes are now as simple as using
|
In #97 @benjamin-thomas tried to implement TodoMVC using their external stylesheet and found it confusing.
Create an example implementing TodoMVC using their stylesheet.
Refactor as necessary to make it not terrible
The text was updated successfully, but these errors were encountered: