8000 Glitching empty area in window mode · Issue #249 · seatgeek/react-infinite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Glitching empty area in window mode #249

Open
sharpensteel opened this issue Nov 8, 2017 · 2 comments

Glitching empty area in window mode #249

sharpensteel opened this issue Nov 8, 2017 · 2 comments

Comments

@sharpensteel
Copy link
sharpensteel commented Nov 8, 2017 •
edited
Loading

In window mode, in page with header, state.displayIndexStart calculated incorrectly, which causes emply space before react-infinite items (see screenshot)

example files to reproduce bug: html + jsx

i created commit that fixesgetScrollTop / setScrollTop so they take into account y-offset of Infinite component on page

screenshot:
image
@bleshik
Copy link
bleshik commented Aug 9, 2018

@sharpensteel could you please create a PR so that it gets merged? The lib works well, except this particular bug.

@elnygren
Copy link

any chance to get this into the codebase? This fix worked for me. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bleshik @elnygren @sharpensteel
0