8000 Godot plugin no longer works with Godot 3.5 · Issue #39 · setzer22/blackjack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.
8000

Godot plugin no longer works with Godot 3.5 #39

Closed
novhack opened this issue Aug 5, 2022 · 6 comments
Closed

Godot plugin no longer works with Godot 3.5 #39

novhack opened this issue Aug 5, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@novhack
Copy link
novhack commented Aug 5, 2022

Godot 3.5 was released today and it seems the way how the plugin exported properties to Godot inspector no longer works or something else changed. Jack Property, Show Gui and Material Slot no longer show up. With the version 3.4.5 it works fine and all properties are shown. I tried it with the plugin and libblackjack_godot.so compiled from the latest main on Arch Linux.
@novhack
Copy link
Author
novhack commented Aug 7, 2022

I discussed these errors with guys from godot-rust and it seems some issues will be addressed with gdnative crate 0.10.1. I tried to compile the plugin with the latest git version of godot-rust but now it crashes the editor when I try to add the blackjackjack node into a scene tree.

@setzer22
Copy link
Owner
setzer22 commented Aug 9, 2022

Hey! Thanks for reporting. I haven't yet had time to test Godot 3.5 with blackjack. I'll have a look at this soon 👍

the way how the plugin exported properties to Godot inspector no longer works or something else changed

I discussed these errors with guys from godot-rust and it seems some issues will be addressed with gdnative crate 0.10.1

The part of the plugin handling the exported properties is written in GDScript, so if that broke maybe it's some change in Godot's internal representation of get_property_list. I will see what I can to 🤔

@setzer22 setzer22 added the bug Something isn't working label Sep 23, 2022
8000
@novhack
Copy link
Author
novhack commented Oct 3, 2022

A new version of gdnative crate 0.11 has been released yesterday. It should support Godot 3.5 however it drops support for older Godot versions.

@setzer22
Copy link
Owner

Still aware of this. If there are no major blockers, I'm planning to push a fix for this in my next PR 👍

@setzer22
Copy link
Owner

This was fixed in the (still unmerged) commit 646a8b5. Still needs a bit more testing, so I will keep this open until I merge the PR (hopefully soon! 🎉)

@setzer22
Copy link
Owner
setzer22 commented Nov 6, 2022 •
edited
Loading

This was fixed in #62 👍

@setzer22 setzer22 closed this as completed Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@setzer22 @novhack
0