8000 [Meta-issue] Notebooks are outdated / non-runnable · Issue #3036 · shap/shap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[Meta-issue] Notebooks are outdated / non-runnable #3036
Open
@thatlittleboy

Description

@thatlittleboy

Background

We should also make sure that our documentation is kept up to date.

A scour through the open issues in this repo and also on StackOverflow shows that the outdated documentation (or lackthereof) is causing confusion among our users.

Just some examples:


Plan

The plan here is to thoroughly go through each and every notebook example that we have, to:

  • Run the notebook from top-to-bottom and ensure there are no errors.
  • Update the prose where necessary to provide better clarity and fix any typos
  • Update the code (where necessary and appropriate) to demonstrate up-to-date API & python features, such as:
    • Replacing the deprecated boston dataset
    • Using the Explanation API for plotting (e.g. shap.plots.beeswarm rather than shap.summary_plot)

An example of such a PR: #3037

Useful info for contributors

To potential contributors (thank you in advance!), please stick to one notebook per PR when contributing.
Also, any help in updating the GPU-related notebooks would be very much appreciated.

We have two linting checks for notebooks, each of which has an "exclude list" that ignores notebooks that haven't been cleaned. When a notebook has been fixed up, it should be removed from the "exclude" list in these places:

  • The run_notebooks_timeout job in scripts/run_notebooks_timeouts.py
  • The nbcheckorder job in .pre-commit-config.yaml

For more details on how to preview the built documentation, see the contributing guide.

TODO

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationRelating to readthedocs, notebooks, and exposition in docstringsgood first issueThis is a fix that might be easier for someone to do as a first contributionhelp wantedIndicates that a maintainer wants help on an issue or pull request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0