Error with cmake_install_prefix and python install path #505
Comments
|
Hello François, thanks for the suggestion of sysconfig. It seems to fail when user do not work inside a virtual env (which is bad but sometimes happen ...). Anyway I think it's a good solution, especially if it works the same way for venv or conda-like installs. I'll have a deeper look into it. Concerning you're installation problem, I'm a bit surprised. With main branch and a default conf when you run e.g. cmake -S -B build ... and after install something like: ls /home/francois/PlatRock/.venv/lib/python3.12/site-packages/siconos init.py pycache _sicpykernel.so _sicpynumerics.so control fromXml.py io kernel.py mechanics numerics.py utils ls /home/francois/Platrock/.venv/lib cmake libsiconos_externals.so.7 libsiconos_io.so libsiconos_kernel.so.7.0.0 libsiconos_numerics.so.7 What is your system and which cmake command line did you run ? |
Hi,
I'm currently trying to update Siconos, still for PlatRock usage. I know @fperignon that you worked hard on Siconos install / python package paths a few months ago, thanks for that. The documentation was improved as well, that's nice !
I'm using Poetry as python package manager but I get a python path-related error on Siconos import, that's why I have a suggestion. Note that the whole idea here is to improve the virtual envs managers compatibility, I'm aware that I could have used
SICONOS_CUSTOM_INSTALLandISOLATED_INSTALLcmake options, but that's not the point.First, I compiled/installed Siconos successfully, with cmake telling me the two main paths:
The first (.venv) dir is the poetry virtual env I'm using with PlatRock / Siconos. Below that, I have classic bin,lib,include,... tree.
After that, I can import siconos within the virtual environment:
But the following fails, probably because of the way install paths are handled:
It turns out that _sicpykernel is installed in
/home/francois/PlatRock/siconos, just like cmake tells. But as a consequence, siconos install is split into two folders, resulting in internal import issue.The same procedure using venv instead of poetry works well, so I dug a little. With venv, the Siconos python package dir is different (note the full
site-packagepath):Looking further in Siconos cmake files, I found here that
PY_INSTALL_DIRrelies onsys.path, more precisely on its last entry. With venv, the last entry is thesite-packagepath, whereas in poetry the last entry is the virtual env root path, and this make_sicpykernel(and others) to reside in a place it is not found when locally importing them.My suggestion is to use standard sysconfig.get_paths() instead of
sys.path, which gives a dict with nice paths that seems consistent across different virtual env managers.purelibkey inside that looks like a good choice, but I didn't checked conda compatiblity.As a conclusion, my suggestion in SiconosInstallSetup.cmake would be to replace L101:
execute_process(COMMAND ${Python_EXECUTABLE} -c "import sys;print(sys.path[-1])" OUTPUT_VARIABLE PY_INSTALL_DIR)with:
execute_process(COMMAND ${Python_EXECUTABLE} -c "import sysconfig;print(sysconfig.get_paths()['purelib'])" OUTPUT_VARIABLE PY_INSTALL_DIR)I'm not sure, but it may also be valid for conda, which would make
IN_CONDAdetection no longer necessary.The text was updated successfully, but these errors were encountered: