-
Notifications
You must be signed in to change notification settings - Fork 883
Closed
Labels
Description
Description
There are a number of validation criteria for blocks and attestations.
Messages from the network hit the router and get validated by the beacon chain. The differing results from invalid messages should result in down-scoring the peer that sent us the message.
There are varying degrees of scoring. We currently have a set of PeerAction's (https://github.com/sigp/lighthouse/blob/master/beacon_node/eth2_libp2p/src/peer_manager/score.rs#L35) which we should map to various validation results.
See the error types here: https://github.com/sigp/lighthouse/blob/master/beacon_node/beacon_chain/src/attestation_verification.rs#L66
and here:
https://github.com/sigp/lighthouse/blob/master/beacon_node/beacon_chain/src/block_verification.rs#L86
@paulhauner might be interested in having a first pass at mapping these types, potentially we may need to add more PeerActions.
EDIT: Seems the attestations errors have already been mapped nicely here:
lighthouse/beacon_node/network/src/router/processor.rs
Lines 604 to 793 in 3c4daec
| match error { | |
| AttnError::FutureEpoch { .. } | |
| | AttnError::PastEpoch { .. } | |
| | AttnError::FutureSlot { .. } | |
| | AttnError::PastSlot { .. } => { | |
| /* | |
| * These errors can be triggered by a mismatch between our slot and the peer. | |
| * | |
| * | |
| * The peer has published an invalid consensus message, _only_ if we trust our own clock. | |
| */ | |
| } | |
| AttnError::InvalidSelectionProof { .. } | AttnError::InvalidSignature => { | |
| /* | |
| * These errors are caused by invalid signatures. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::EmptyAggregationBitfield => { | |
| /* | |
| * The aggregate had no signatures and is therefore worthless. | |
| * | |
| * Whilst we don't gossip this attestation, this act is **not** a clear | |
| * violation of the spec nor indication of fault. | |
| * | |
| * This may change soon. Reference: | |
| * | |
| * https://github.com/ethereum/eth2.0-specs/pull/1732 | |
| */ | |
| } | |
| AttnError::AggregatorPubkeyUnknown(_) => { | |
| /* | |
| * The aggregator index was higher than any known validator index. This is | |
| * possible in two cases: | |
| * | |
| * 1. The attestation is malformed | |
| * 2. The attestation attests to a beacon_block_root that we do not know. | |
| * | |
| * It should be impossible to reach (2) without triggering | |
| * `AttnError::UnknownHeadBlock`, so we can safely assume the peer is | |
| * faulty. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::AggregatorNotInCommittee { .. } => { | |
| /* | |
| * The aggregator index was higher than any known validator index. This is | |
| * possible in two cases: | |
| * | |
| * 1. The attestation is malformed | |
| * 2. The attestation attests to a beacon_block_root that we do not know. | |
| * | |
| * It should be impossible to reach (2) without triggering | |
| * `AttnError::UnknownHeadBlock`, so we can safely assume the peer is | |
| * faulty. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::AttestationAlreadyKnown { .. } => { | |
| /* | |
| * The aggregate attestation has already been observed on the network or in | |
| * a block. | |
| * | |
| * The peer is not necessarily faulty. | |
| */ | |
| } | |
| AttnError::AggregatorAlreadyKnown(_) => { | |
| /* | |
| * There has already been an aggregate attestation seen from this | |
| * aggregator index. | |
| * | |
| * The peer is not necessarily faulty. | |
| */ | |
| } | |
| AttnError::PriorAttestationKnown { .. } => { | |
| /* | |
| * We have already seen an attestation from this validator for this epoch. | |
| * | |
| * The peer is not necessarily faulty. | |
| */ | |
| } | |
| AttnError::ValidatorIndexTooHigh(_) => { | |
| /* | |
| * The aggregator index (or similar field) was higher than the maximum | |
| * possible number of validators. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::UnknownHeadBlock { beacon_block_root } => { | |
| // Note: its a little bit unclear as to whether or not this block is unknown or | |
| // just old. See: | |
| // | |
| // https://github.com/sigp/lighthouse/issues/1039 | |
| // TODO: Maintain this attestation and re-process once sync completes | |
| debug!( | |
| self.log, | |
| "Attestation for unknown block"; | |
| B421 | "peer_id" => peer_id.to_string(), |
| "block" => format!("{}", beacon_block_root) | |
| ); | |
| // we don't know the block, get the sync manager to handle the block lookup | |
| self.send_to_sync(SyncMessage::UnknownBlockHash(peer_id, beacon_block_root)); | |
| } | |
| AttnError::UnknownTargetRoot(_) => { | |
| /* | |
| * The block indicated by the target root is not known to us. | |
| * | |
| * We should always get `AttnError::UnknwonHeadBlock` before we get this | |
| * error, so this means we can get this error if: | |
| * | |
| * 1. The target root does not represent a valid block. | |
| * 2. We do not have the target root in our DB. | |
| * | |
| * For (2), we should only be processing attestations when we should have | |
| * all the available information. Note: if we do a weak-subjectivity sync | |
| * it's possible that this situation could occur, but I think it's | |
| * unlikely. For now, we will declare this to be an invalid message> | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::BadTargetEpoch => { | |
| /* | |
| * The aggregator index (or similar field) was higher than the maximum | |
| * possible number of validators. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::NoCommitteeForSlotAndIndex { .. } => { | |
| /* | |
| * It is not possible to attest this the given committee in the given slot. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::NotExactlyOneAggregationBitSet(_) => { | |
| /* | |
| * The unaggregated attestation doesn't have only one signature. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::AttestsToFutureBlock { .. } => { | |
| /* | |
| * The beacon_block_root is from a higher slot than the attestation. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::InvalidSubnetId { received, expected } => { | |
| /* | |
| * The attestation was received on an incorrect subnet id. | |
| */ | |
| debug!( | |
| self.log, | |
| "Received attestation on incorrect subnet"; | |
| "expected" => format!("{:?}", expected), | |
| "received" => format!("{:?}", received), | |
| ) | |
| } | |
| AttnError::Invalid(_) => { | |
| /* | |
| * The attestation failed the state_processing verification. | |
| * | |
| * The peer has published an invalid consensus message. | |
| */ | |
| } | |
| AttnError::BeaconChainError(e) => { | |
| /* | |
| * Lighthouse hit an unexpected error whilst processing the attestation. It | |
| * should be impossible to trigger a `BeaconChainError` from the network, | |
| * so we have a bug. | |
| * | |
| * It's not clear if the message is invalid/malicious. | |
| */ | |
| error!( | |
| self.log, | |
| "Unable to validate aggregate"; | |
| "peer_id" => peer_id.to_string(), | |
| "error" => format!("{:?}", e), | |
| ); | |
| } | |
| } |