8000 Re-enable Fulu execution_payload tests · Issue #7547 · sigp/lighthouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-enable Fulu execution_payload tests #7547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

A 8000 lready on GitHub? Sign in to your account

Jump to bottom
Open
michaelsproul opened this issue Jun 3, 2025 · 0 comments
Open

Re-enable Fulu execution_payload tests #7547

michaelsproul opened this issue Jun 3, 2025 · 0 comments
Labels
blocked consensus An issue/PR that touches consensus code, such as state_processing or block verification. das Data Availability Sampling spec_change A change related to the Eth2 spec

Comments

@michaelsproul
Copy link
Member

When spec v1.6.0-alpha.1 is released we need to re-enable the tests disabled by this PR:

The issue is that we are currently ahead of the spec release v1.6.0-alpha.0, but up to date with dev and devnet-0:

lighthouse/consensus/types/src/chain_spec.rs

Lines 656 to 659 in cd83d8d

/// Return the value of `MAX_BLOBS_PER_BLOCK` for the given `epoch`.
/// NOTE: this function is *technically* not spec compliant, but
/// I'm told this is what the other clients are doing for `devnet-0`..
pub fn max_blobs_per_block(&self, epoch: Epoch) -> u64 {

We can remove that comment as well when making this change.

The main thing to remove is the skipped known failure:

lighthouse/testing/ef_tests/src/cases/operations.rs

Lines 577 to 586 in d86233d

// FIXME(das): remove this once v1.6.0-alpha.1 is released
// We are ahead of the v1.6.0-alpha.0 spec in our implementation of
// `get_max_blobs_per_block`, so we fail the execution payload test which expects the
// empty blob schedule to generate an error.
if O::handler_name() == "execution_payload"
&& fork_name == ForkName::Fulu
&& _case_index == 32
{
return Err(Error::SkippedKnownFailure);
}

@michaelsproul michaelsproul added spec_change A change related to the Eth2 spec blocked consensus An issue/PR that touches consensus code, such as state_processing or block verification. das Data Availability Sampling labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked consensus An issue/PR that touches consensus code, such as state_processing or block verification. das Data Availability Sampling spec_change A change related to the Eth2 spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul
0