8000 Unmarshal error on RTM, after updated to the new Slack version · Issue #630 · slack-go/slack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unmarshal error on RTM, after updated to the new Slack version #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nazariinovak opened this issue Nov 6, 2019 · 7 comments
Closed

Unmarshal error on RTM, after updated to the new Slack version #630

nazariinovak opened this issue Nov 6, 2019 · 7 comments

Comments

@nazariinovak
Copy link
nazariinovak commented Nov 6, 2019 •
edited
Loading

Hello,

We have a bot, that is set up something like

go s.rtm.ManageConnection()
...
for {
			select {
			case msg, ok := <-sh.rtm.IncomingEvents:
fmt.Printf("receivedMessage: %+v\n", msg)
                        ...
}

And when we're debugging in that fmt.Printf, we receive different messages if we ping the bot from older versions of slack on mobile vs the new slack on desktop

Old version (mobile) debugging:

receivedMessage: &{Msg:{Type:message Channel:<redacted> User:<redacted> Text:ping Timestamp:1573030654.004800 ThreadTimestamp: IsStarred:false PinnedTo:[] Attachments:[] Edited:<nil> LastRead: Subscribed:false UnreadCount:0 SubType: Hidden:false DeletedTimestamp: EventTimestamp:1573030654.004800 BotID: Username: Icons:<nil> Inviter: Topic: Purpose: Name: OldName: Members:[] ReplyCount:0 Replies:[] ParentUserId: Files:[] Upload:false Comment:<nil> ItemType: ReplyTo:0 Team:<redacted> Reactions:[] ResponseType: ReplaceOriginal:false DeleteOriginal:false Blocks:{BlockSet:[]}} SubMessage:<nil> PreviousMessage:<nil>}

New version (desktop) debugging:

receivedMessage: {Type:unmarshalling_error Data:RTM Error: Could not unmarshall event "message": {"client_msg_id":<redacted>,"suppress_notification":false,"type":"message","text":"ping","user":<redacted>,"team":<redacted>,"blocks":[{"type":"rich_text","block_id":"tHJFI","elements":[{"type":"rich_text_section","elements":[{"type":"text","text":"ping"}]}]}],"user_team":<redacted>,"source_team":<redacted>,"channel":<redacted>,"event_ts":"1573030640.004600","ts":"1573030640.004600"}}

Are there any problems now with the new slack version, so they send a different kind of event now or something?
@nazariinovak
Copy link
Author
nazariinovak commented Nov 6, 2019 •
edited
Loading

It looks like before, this was the struct that parsed the incoming event https://github.com/nlopes/slack/blob/master/messages.go#L16-L20

But slack changed the type "message" object to {"client_msg_id":<redacted>,"suppress_notification":false,"type":"message","text":"ping","user":<redacted>,"team":<redacted>,"blocks":[{"type":"rich_text","block_id":"tHJFI","elements":[{"type":"rich_text_section","elements":[{"type":"text","text":"ping"}]}]}],"user_team":<redacted>,"source_team":<redacted>,"channel":<redacted>,"event_ts":"1573030640.004600","ts":"1573030640.004600"}?

@cilla-md
Copy link
cilla-md commented Nov 6, 2019

Info from slack:
However, it does seem that the culprit is with changes to the message payloads due to the WYSIWYG change and that was mentioned in our change log here indicating that you'd start to get "type": "rich_text_section" in your payloads:

https://api.slack.com/changelog/2019-09-what-they-see-is-what-you-get-and-more-and-less

@DenKoren
Copy link
DenKoren commented Nov 12, 2019 •
edited
Loading

It seems that fix is already in master, but not yet tagged.
The current behaviour of v0.6.0 makes work with messages impossible through RTM IncomingEvents.
Is it possible to put patch to actual v0.6.0 version and tag it with v0.6.1 to make code work as a quickfix?

The problem is caused by 'rich_text' block that is considered 'unknown' by v0.6.0. This causes "unsupported block type" unmarshalling error

@nazariinovak
Copy link
Author

Can confirm that it works with the latest version from master

@DenKoren
Copy link
DenKoren commented Nov 12, 2019 •
edited
Loading

Yes, the fix is in block_conv.go file in switch expression where the block type is detected.

// UnmarshalJSON implements the Unmarshaller interface for Blocks, so that any JSON
// unmarshalling is delegated and proper type determination can be made before unmarshal
func (b *Blocks) UnmarshalJSON(data []byte) error {

		...

		switch blockType {
		case "actions":
			block = &ActionBlock{}
		case "context":
			block = &ContextBlock{}
		case "divider":
			block = &DividerBlock{}
		case "image":
			block = &ImageBlock{}
		case "section":
			block = &SectionBlock{}
		case "rich_text":
			// for now ignore the (complex) content of rich_text blocks until we can fully support it
			continue
		default:
			return errors.New("unsupported block type")
		}

To fix problem in v0.6.0 the

		case "rich_text":
			// for now ignore the (complex) content of rich_text blocks until we can fully support it
			continue

is enough to be added to that switch, exactly like it is done in master.

@DenKoren
Copy link
DenKoren commented Nov 12, 2019 •
edited
Loading

Unfortunately I can't make a PR to your repo since it is required to have target branch existing for PR.
If I understand the versioning flow of this project correctly, to fix the bug we need:

git checkout v0.6.0 // checkout to the tag
git cherry-pick c4750fe73d883a2b1edff13e0d2e09290512b405 // copy the fix from master to current branch
git tag v0.6.1 // bump version
git push --tags // push the changes into github

@PrasadG193 PrasadG193 mentioned this issue Nov 19, 2019
Closed
@janza janza mentioned this issue Nov 19, 2019
Merged
@ConnerEnders ConnerEnders mentioned this issue Nov 20, 2019
Closed
@SmilingNavern
Copy link
Contributor

It's fixed in #618 and latest master works fine. Would be great to have tagged release for this.

jmatsu referenced this issue in jmatsu/terraform-provider-slack Nov 25, 2019
@jmatsu
Updated nlopes/slack to the current master
818cac8 
Because of https://github.com/nlopes/slack/issues/630
@jmatsu jmatsu mentioned this issue Nov 25, 2019
Merged
jmatsu referenced this issue in jmatsu/terraform-provider-slack Nov 25, 2019
@jmatsu
Updated nlopes/slack to the current master
7f16f9c 
Because of https://github.com/nlopes/slack/issues/630
@andysnowden andysnowden mentioned this issue Nov 25, 2019
Closed
@alexandre-normand alexandre-normand mentioned this issue Dec 2, 2019
Merged
3 tasks
Crazybus referenced this issue in Crazybus/moonsla Dec 4, 2019
@Crazybus
Upgrade slack library to fix private messages
39c4878 
Slack made some API changes (for the lovely WYSIWYG editor) which broke
the ability for this library to parse private messages. Upstream issue https://github.com/nlopes/slack/issues/630
@Crazybus Crazybus mentioned this issue Dec 4, 2019
Merged
@jankremlacek jankremlacek mentioned this issue Dec 9, 2019
Merged
@ldkingvivi ldkingvivi mentioned this issue Dec 17, 2019
Closed
fgrosse referenced this issue in go-joe/slack-adapter Jan 22, 2020
@fgrosse
Update slack client to latest version (master)
ba01bd5 
This works around the issue described at https://github.com/nlopes/slack/issues/630
@wass3r wass3r mentioned this issue Feb 9, 2020
Merged
5 tasks
@nlopes nlopes closed this as completed Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nlopes @SmilingNavern @DenKoren @nazariinovak @cilla-md
0