Revert "Remove the listening? node info property (#1050)"
#1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjyoungblood
approved these changes
Jun 5, 2025
|
Could you say why the commit is being reverted in the commit message? |
It was removed on the basis of the Z-Wave documentation at "5.2.5.4.4. Node info cached report" describing the `List.` bit as ``` List (1 bit)The Optional Functionality bit indicates if true ( == '1') the node supports more command classes in addition to the ones covered by the device classes listed in this message. The additional command classes follow the device class fields. ``` The official documentation is wrong here. The `List` bit does indicate whether or not the device is "mains powered" and thus constantly listening. See "2.1.4.2. Application Specific Part" in the Z-Wave documentation for a description of the `listening` flag which value is the same as the `List.` bit in the Node Info Cached Report command.
ce8b394 to
11dfee8
Compare
fhunleth
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed on the basis of the Z-Wave documentation at "5.2.5.4.4. Node info cached report" describing the
List.bit asThe official documentation is wrong here. The
Listbit does indicate whether or not the device is "mains powered" and thus constantly listening.See "2.1.4.2. Application Specific Part" in the Z-Wave documentation for a description of the
listeningflag which value is the same as theList.bit in the Node Info Cached Report command.