This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat(commitment): add KZG commitment #317
Comments
|
Here is the background of this issue: When we create prover object for zkevm circuit: https://github.com/scroll-tech/scroll-prover/blob/main/integration/tests/inner_tests.rs#L18 It will call this function: https://github.com/scroll-tech/zkevm-circuits/blob/develop/prover/src/common/prover.rs#L34 As we can see that the parameter object is a binary file encoding information of As for Sirius, we will do something similar that create a Sirius prover from these parameters. |
pub fn default_value();
pub fn len() -> usize;
pub fn setup(...) -> Self;
pub fn commit(...) -> Result<C, Error> |
|
After I looked into detail, the kzg commitment is used in snark-verifier. As for folding, we can still use pederson commitment. While we can add kzg commitment feature, it is not urgent right now. @cyphersnake |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Currently, we are using pedersen commitment scheme. To fold circuit that based on kzg commitment like zkEVM circuit, we need also support. the kzg commitment
The text was updated successfully, but these errors were encountered: