8000 Fastboot fails if loading from the same snapshot multiple times · Issue #35376 · solana-labs/solana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fastboot fails if loading from the same snapshot multiple times #35376
Closed
anza-xyz/agave
#58
@brooksprumo

Description

@brooksprumo

Problem

If we startup and fastboot load from a snapshot,
then crash before another snapshot is taken AND after shrink has run
then restart and fastboot load from the same snapshot,
we may crash

This is due to the call to shrink.

If the snapshot is for slot 100, and then we shrink up to slot 110, the account storage files may (will) have changed. Thus, if we fastboot again from slot 100, there will be a mismatch between what's on disk (storage files for slot 110), and what the snapshot expects (storage files for slot 100).

Initially reported in #35190

Original fastboot project item: Fastboot (view)

Proposed Solution

One way is to prevent fastboot from loading the same snapshot multiple times (#35350). I'd prefer to find a real fix though.

Potentially we can:
At startup, after fastboot loading from a snapshot, get all the snapshot storages. Then pass these snapshots storages to AccountsHashVerifier as the "initial snapshot storages" for it to hold internally. AHV already does this for new snapshots; this solution extends AHV to also cover the storages used at startup.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0