feat(swabbie): html endpoints for optOut and restore #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private String getHtmlWithMessage(String namespace, String resourceId, String message) { | ||
| return "<body>\n" + | ||
| "Swabbie Resource: [namespace=" + namespace + ", resourceId=" + resourceId + "] \n" + |
There was a problem hiding this comment.
HTML treats \n as just whitespace. Did you want this to show up on a new line?
Suggested change
| "Swabbie Resource: [namespace=" + namespace + ", resourceId=" + resourceId + "] \n" + | |
| "Swabbie Resource: [namespace=" + namespace + ", resourceId=" + resourceId + "] <br>\n" + |
f25870f to
95ca681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an html response for opt out.
Adding an endpoint for getting a resource.
Adding the framework for a restore endpoint, but holding off on exposing it until aws gives us soft delete. If that won't happen, I'll remove the endpoint.