chore(dependencies): upgrades to spring-boot 2 and spring-security 5 #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - this compiles but many tests are broken
Reworks authentication using spring security 5.
fixes excess logging from AuthenticatedRequest updates
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
|
LGTM! |
dibyom
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses kork BOM for dependency management.
The most significant change in here is that with Spring-Security 5 each WebSecurityConfigurerAdapter creates its own filter chain, and the first (by
@Order) that matches a request will handle that request.In kork we moved the couple of WebSecurityConfigurerAdapters to high precidence, and restricted them to only match requests to the relevant paths (/health, /metrics).
In gate we support one type of SSO / user facing auth enabled, as well as x509.
The WebSecurityConfigurerAdapter for x509 is set to match any request but at a lower-than-default precidence (2000) while the other WebSecurityConfigurerAdapters remain at order 1000 and install a request matcher that checks whether there are multiple ports configured in the web server. If so, it will only match requests where the localPort equals the server.port allowing x509 auth to handle any other API ports that are configured.