8000 rename admindb package to roomdb · Issue #57 · ssbc/go-ssb-room · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rename admindb package to roomdb #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking &ldqu 8000 o;Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cryptix opened this issue Mar 3, 2021 · 1 comment · Fixed by #74
Closed

rename admindb package to roomdb #57

cryptix opened this issue Mar 3, 2021 · 1 comment · Fixed by #74
Assignees
@cryptix
Labels
Go golang related stuff

Comments

@cryptix
Copy link
Member
cryptix commented Mar 3, 2021

One thing I kept thinking: since this package takes care of persisting all the data, then maybe admindb isn't really descriptive? roomdb might be better; admindb implies being concerned with a database of admins, I think, suggesting the presence of other databases as well.

Originally posted by @cblgh in #55 (comment)
@cryptix cryptix changed the title rename admindb to roomdb rename admindb package to roomdb Mar 3, 2021
@cryptix cryptix mentioned this issue Mar 3, 2021
Merged
7 tasks
@cryptix
Copy link
Member Author
cryptix commented Mar 5, 2021 •
edited
Loading

related tasks:

  • unify receiver names of handlers and database
  • move tests to muxrpc/tests

@cryptix cryptix self-assigned this Mar 5, 2021
@cryptix cryptix mentioned this issue Mar 10, 2021
Merged
10 tasks
@cryptix cryptix added the Go golang related stuff label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptix cryptix

Labels
Go golang related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The big rename ssbc/go-ssb-room
1 participant
@cryptix
0