Logo fix #33
Merged
Logo fix #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 25 25
Lines 1686 1686
=====================================
Hits 1385 1385
Misses 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arturtoshev
approved these changes
Jan 1, 2025
| - name: Install Ruff from pyproject.toml | ||
| uses: astral-sh/ruff-action@v3 | ||
| with: | ||
| version-file: "pyproject.toml" |
There was a problem hiding this comment.
Looking at the github action logs, reading the version from pyproject.toml didn't actually work and the latest version was used. But this doesn't matter at this point.
| @@ -80,7 +80,8 @@ exclude = [ | |||
| ".venv", | |||
| "venv", | |||
| "docs/_build", | |||
| "dist" | |||
| "dist", | |||
| "notebooks", | |||
There was a problem hiding this comment.
Not linting the notebooks is how failing ruff is solved for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.