8000 Use `content-tag` in `@glint/environment-ember-template-imports` · Issue #609 · typed-ember/glint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Use content-tag in @glint/environment-ember-template-imports #609
Closed
@NullVoxPopuli

Description

@NullVoxPopuli

ember-template-imports is an implementation detail of a feature, where those implementation details are being phased out.
For example, ember-template-imports is not used within the v2-addon blueprint (with rollup -- there is a rust plugin that handles the transform, per RFC: emberjs/rfcs#933), and @embroider/vite uses that same plugin in apps, and actually breaks with ember-template-imports present (one too many transforms are happening).

So, I think Glint should also use https://www.npmjs.com/package/content-tag

However, because how Glint handles <template> is an implementation details, there is another approach as well. There is a javascript implementation of content-tag used in this PR:
https://github.com/ember-cli/eslint-plugin-ember/pull/1920/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestrefactorMoving things around

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0