8000 [BUG] WYSIWYG doesn't follow dark mode · Issue #2279 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] WYSIWYG doesn't follow dark mode #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AbdelrhmanSaid opened this issue Apr 21, 2025 · 3 comments
Open

[BUG] WYSIWYG doesn't follow dark mode #2279

AbdelrhmanSaid opened this issue Apr 21, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@AbdelrhmanSaid
Copy link
Contributor

Browser

Chrome

OS

Windows 11

Screen size

1920x1080

Describe the bug

You can see the bug here

Image

How to reproduce

  1. Go to 'https://preview.tabler.io/wysiwyg.html'
  2. See error

Screenshots

No response

JSFiddle

No response
@AbdelrhmanSaid AbdelrhmanSaid added the bug Something isn't working label Apr 21, 2025
@AbdelrhmanSaid AbdelrhmanSaid changed the title [BUG] TinyMCE doesn't follow dark mode [BUG] WYSIWYG doesn't follow dark mode Apr 21, 2025
@ethancrawford
Copy link
Collaborator
ethancrawford commented Apr 22, 2025 •
edited
Loading

@AbdelrhmanSaid - if I'm reading things correctly, then it looks like this is something planned but still in progress. There are references in the source code to a tablerTheme variable that is not yet defined:

Nope, I read it incorrectly 😉 there are references to both tabler-theme and tablerTheme variables, so chances are this was an oversight when renaming it at some point.

tabler/shared/includes/ui/wysiwyg.html

Lines 28 to 33 in f25da87

if (localStorage.getItem("tablerTheme") === 'dark') {
options.skin = 'oxide-dark';
options.content_css = 'dark';
}
hugeRTE.init(options);

I've tested renaming this reference to tabler-theme locally and it appears to work fine after that 🤞 🙂

@AbdelrhmanSaid
Copy link
Contributor Author

I guess that's the issue, thanks

@ethancrawford
Copy link
Collaborator

@codecalm - I'm not sure this is fixed, the editor still looks like the screenshot above... there is still a mismatch between how the theme setting is stored in localStorage (see above comments) and how it is retrieved, as seen below:

tabler/core/js/tabler-theme.js

Line 23 in 7082ea1

localStorage.setItem('tabler-' + key, param)

@ethancrawford ethancrawford reopened this May 12, 2025
@ethancrawford ethancrawford mentioned this issue May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codecalm @ethancrawford @AbdelrhmanSaid
0