8000 Modal backgrounds on preview's modals page obscure other important page elements · Issue #2309 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modal backgrounds on preview's modals page obscure other important page elements #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethancrawford opened this issue May 1, 2025 · 0 comments

Comments

@ethancrawford
Copy link
Collaborator
ethancrawford commented May 1, 2025

Browser

N/A

OS

N/A

Screen size

N/A

Describe the bug

Several important page elements on the preview modals page are obscured by the containers that wrap each of the live modal examples on the page. These modal containers have a z-index that evaluates to 1055, set by Bootstrap at /core/node_modules/bootstrap/scss/_modal.scss. The page elements that this obscures include:

  • Top navigation bar menu items, whose z-index evaluates to 1030. When the dropdown menu items in the top navigation bar are expanded, they end up appearing behind the live modal examples on the page.
    navbar menu items z-index set here:
    z-index: $zindex-fixed;
  • (On smaller-screen devices such as mobiles): the new theme settings sidepanel and the button in the bottom left hand corner of the page that triggers it, whose z-indexes evaluate to 1045 and 1030 respectively.
    sidepanel's offcanvas z-index set by Bootstrap at /core/node_modules/bootstrap/scss/_offcanvas.scss and trigger button's z-index set here:
    z-index: $zindex-fixed;

It would make sense to me that rather than making the modals visible on page load, they are initially hidden. Then, they are only made visible on clicking buttons - upon which, the background/backdrop covers the whole screen.
If it's preferred to keep the modals visible on page load, then the z-indexes of the preview's modals and/or of the elements they conflict with will need adjusting.

How to reproduce

Top navigation conflict:

  1. Go to https://preview.tabler.io/modals.html
  2. Click on any dropdown menu in the top navigation
  3. Observe that the modal examples on the page overlap the expanded navigation menu.

Theme sidepanel conflict:

  1. Using a mobile phone or browser's developer tools to view the page in mobile view, go to https://preview.tabler.io/modals.html
  2. Observe that the modal examples on the page overlap the theme settings button
  3. Scroll to a part of the page where the button is not hidden by the modals
  4. Click the button to show the theme settings sidepanel
  5. Observe that the modal examples on the page overlap the theme settings sidepanel.

Screenshots

Image

Image

Image

JSFiddle

No response

@ethancrawford ethancrawford added bug Something isn't working and removed bug Something isn't working labels May 1, 2025
@ethancrawford ethancrawford changed the title [BUG] Top navigation bar items obscured on preview's modals page Modal backgrounds on preview's modals page obscure other important page elements May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0