8000 [BUG] v1.2.0 broke the boxed layout · Issue #2340 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] v1.2.0 broke the boxed layout #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lovasoa opened this issue May 6, 2025 · 2 comments · Fixed by #2357
Closed

[BUG] v1.2.0 broke the boxed layout #2340

lovasoa opened this issue May 6, 2025 · 2 comments · Fixed by #2357
Labels
bug Something isn't working

Comments

@lovasoa
Copy link
Contributor
lovasoa commented May 6, 2025 •
edited
Loading

Describe the bug

The boxed layout has a top padding, but since v1.2.0 it is overridden by a new padding: 0 !important; rule that applies directly to the body element.

<body class="layout-boxed"> <!-- This element is supposed to have a padding, but since v1.2, it gets overridden --> 
  <div class="page">
     <div class="page-wrapper">
       <main class="page-body">
         Hello world
       </main>
      </div>
  </div>
</body>

How to reproduce

  1. Go to https://codepen.io/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-/pen/oggyNeM
  2. Compare with https://codepen.io/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-/pen/YPPvzxR

The bug is also visible on https://preview.tabler.io/layout-boxed.html

Screenshots

Image

Image

Image

JSFiddle

https://codepen.io/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-/pen/oggyNeM
@lovasoa lovasoa added the bug Something isn't working label May 6, 2025
@ethancrawford
Copy link
Collaborator

Introduced here: 137e5be

@ethancrawford
Copy link
Collaborator

It would be a shame to add more instances of it to the code, but it may be enough to just add !important to the padding property here:

tabler/core/scss/layout/_core.scss

Line 42 in 9b15b94

padding: 1rem;

@codecalm codecalm mentioned this issue May 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary !important from body padding tabler/tabler
2 participants
@lovasoa @ethancrawford
0