8000 Masking implementation confusion · Issue #18 · tencent-ailab/grover · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Masking implementation confusion #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yuewan2 opened this issue Jun 26, 2023 · 0 comments
Open

Masking implementation confusion #18

yuewan2 opened this issue Jun 26, 2023 · 0 comments

Comments

@yuewan2
Copy link
yuewan2 commented Jun 26, 2023

In the paper, it mentions that you apply random masking on atom and bonds. It also says that "GROVER randomly masks a local subgraph". However, in the GroverCollator class, the 'atom_random_mask' and 'bond_random_mask' are only designed for selecting atom/bond context without applying any masking on the input molecule representation. I am wondering if there is anything I missed from the code since I do not see any molecule masking implementation elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuewan2
0