8000 DPL tests with timestamps should include a timezone · Issue #579 · teragrep/pth_10 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DPL tests with timestamps should include a timezone #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elliVM opened this issue May 2, 2025 · 0 comments
Open

DPL tests with timestamps should include a timezone #579

elliVM opened this issue May 2, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@elliVM
Copy link
Contributor
elliVM commented May 2, 2025 •
edited
Loading

Describe the bug
Many tests quries for DPL have incorrect or missing timezone information. Current implementation of default timestamps means that the system default timezone is used. This can cause variance in test results between timezones.

To avoid this all dpl queries with timestamps should have zone information included!

earliest=2020-01-01T00:00:00 should be earliest=2020-01-01T00:00:00Z with Z for UTC.

earliest=2020-01-01T00:00:00z should be earliest=2020-01-01T00:00:00Z with upper case Z for proper format.

same applies for latest.

UTC is preferred for clarity.

Expected behavior
Tests should always have same results even when system timezone is changed.

How to reproduce
For direct result write a dpl test query or modify one with timestamps and inspect the ctx.getSparkQuery(). It will have different results if system default timezone is changed. query part where epoch is visible from_unixtime(1611619200, yyyy-MM-dd HH:mm:ss)

Software version
8.4.2

Additional context
Note that most of the test cases work even with small variance in the timezones.

$ grep -rlE '(earliest|latest)' . check for files with timestamps in src/test
@elliVM elliVM added the bug Something isn't working label May 2, 2025
@elliVM elliVM changed the title DPL tests with timestamps should timezone DPL tests with timestamps should include a timezone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elliVM
0